Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Brightness & Contrast' and 'Hue' effects not doing very well #4506

Closed
DanPinGF opened this issue Oct 26, 2021 · 12 comments · Fixed by OpenShot/libopenshot#889
Closed

'Brightness & Contrast' and 'Hue' effects not doing very well #4506

DanPinGF opened this issue Oct 26, 2021 · 12 comments · Fixed by OpenShot/libopenshot#889

Comments

@DanPinGF
Copy link

DanPinGF commented Oct 26, 2021

Describe the bug:
The 'Brightness & Contrast' and 'Hue' effects in OpenShot have gone into a glitchy state since 2.6.0, making them completely useless.

Steps to reproduce the behavior:

  1. Go to 'Effects'
  2. Drag 'Brightness & Contrast' or 'Hue' to any video or image
  3. Adjust the value of 'Brightness' above 0, for instance 0.08 (for 'Hue', this is done similarly)
  4. Problem result explained below.

Expected behavior:
It should render correctly like in prior versions. However, the 'Brightness & Contrast' and 'Hue' effects seem to be broken since 2.6.0, resulting in glitching artifacts on the preview, and on export as well.

System Details:

  • OpenShot Version: 2.6.1
  • Operating System / Distro: Windows 11

Log Files:
N/A

Exception / Stacktrace:
N/A

Screenshots: (Optional)
image

@DanPinGF DanPinGF changed the title 'Brightness & Contrast' effect not doing very well 'Brightness & Contrast' and 'Hue' effects not doing very well Dec 8, 2021
@stale
Copy link

stale bot commented Jun 12, 2022

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.

This issue will be closed, as it meets the following criteria:

  • No activity in the past 180 days
  • No one is assigned to this issue

We'd like to ask you to help us out and determine whether this issue should be reopened.

  • If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention.
  • If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.

Thanks again for your help!

@stale stale bot added the stale This issue has not had any activity in 60 days :( label Jun 12, 2022
@DanPinGF
Copy link
Author

@JacksonRG - This issue still needs to be resolved.

@JacksonRG
Copy link
Collaborator

@DanPinGF Heres the behavior I'm seeing for those effects. (Same on windows as well) Could you show me what glitchy behavior you're seeing?

HueAndBrightness-2022-06-14_20.14.16.mp4

@stale stale bot removed the stale This issue has not had any activity in 60 days :( label Jun 15, 2022
@DanPinGF
Copy link
Author

@JacksonRG - When applying the 'Brightness & Contrast' or 'Hue' effects to an image that has alpha (transparency), no matter the value or intensity, they produce irregular colors on the affected image (see screenshot below).

image

You can see here that, with 'Brightness & Contrast' applied to one of the images containing alpha (bottom left), as the video progresses, color distortion occurs, resulting in a crappy color corruption effect.

@JacksonRG
Copy link
Collaborator

Can you share the project file? I'm confused about the effect you're trying to achieve

@DanPinGF
Copy link
Author

@JacksonRG - This is the project:

image

The image selected in the timeline has the 'Brightness & Contrast effect applied to it.

@stale
Copy link

stale bot commented Dec 21, 2022

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.

This issue will be closed, as it meets the following criteria:

  • No activity in the past 180 days
  • No one is assigned to this issue

We'd like to ask you to help us out and determine whether this issue should be reopened.

  • If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention.
  • If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.

Thanks again for your help!

@stale stale bot added the stale This issue has not had any activity in 60 days :( label Dec 21, 2022
@DanPinGF
Copy link
Author

@JacksonRG - The problem continues to persist as of version 3.0.0. It has never been fixed in the Daily Builds.

@stale stale bot removed the stale This issue has not had any activity in 60 days :( label Dec 21, 2022
@jonoomph
Copy link
Member

Taking a look now

@jonoomph
Copy link
Member

Yup, this is very strange! I can successfully reproduce it.

@Colorjet3
Copy link
Collaborator

@jonoomph I created a Trello card for this in the Backlog board.

@jonoomph
Copy link
Member

jonoomph commented Dec 22, 2022

A new daily build should be ready in about an hour with the fix for the following effects:

  • Hue
  • Brightness & Contrast
  • Saturation

https://www.openshot.org/download/#daily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants