Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Simplify the code #3738

Merged
merged 3 commits into from
Sep 26, 2020
Merged

STY: Simplify the code #3738

merged 3 commits into from
Sep 26, 2020

Conversation

MartinThoma
Copy link
Contributor

I used my tool flake8-simplify (version 0.4.1) to find those.
I didn't use contextlib.suppress as I wasn't certain what people think about that.

I used my tool flake8-simplify (version 0.4.1) to find those.
I didn't use contextlib.suppress.
Copy link
Contributor

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I've been wanting to hit a lot of these for a while now.

I added some discussion/suggestions, but all purely discretionary and entirely open to debate.

src/windows/main_window.py Outdated Show resolved Hide resolved
src/windows/models/files_model.py Outdated Show resolved Hide resolved
src/windows/models/properties_model.py Show resolved Hide resolved
src/windows/views/timeline_webview.py Outdated Show resolved Hide resolved
src/windows/views/timeline_webview.py Outdated Show resolved Hide resolved
src/windows/views/timeline_webview.py Outdated Show resolved Hide resolved
MartinThoma and others added 2 commits September 26, 2020 12:40
Thank you, ferdnyc!

Co-authored-by: Frank Dana <ferdnyc@gmail.com>
@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 26, 2020

Well, it all looks great to me, and some quick testing showed that Context menus and cut-and-paste still work as expected on the Timeline, so let's git 'er done. Thanks again @MartinThoma .

@ferdnyc ferdnyc merged commit 917c125 into OpenShot:develop Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants