Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve omit_static_information field description #790

Merged
merged 4 commits into from
May 6, 2024
Merged

Improve omit_static_information field description #790

merged 4 commits into from
May 6, 2024

Conversation

FabianPfeuffer
Copy link
Contributor

@FabianPfeuffer FabianPfeuffer commented Mar 18, 2024 •
edited
Loading

Reference to a related issue in the repository

#770

Add a description

A slight improvement and additional information for the description of the SensorViewConfiguration's omit_static_information data field.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@thomassedlmayer thomassedlmayer mentioned this pull request Mar 22, 2024
Merged
pmai
pmai approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar fix, but otherwise looks good.

osi_sensorviewconfiguration.proto Outdated Show resolved Hide resolved
@pmai pmai self-assigned this Apr 5, 2024
@pmai pmai added this to the V3.7.0 milestone Apr 5, 2024
@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 5, 2024
@jdsika
Copy link
Contributor

jdsika commented Apr 24, 2024

Reviewed for v3.7.0

@pmai
Copy link
Contributor

pmai commented May 6, 2024

CCB 2024-05-06: Merge as-is after way to link to OSMP is checked with ASAM Office/Editors.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 6, 2024
FabianPfeuffer and others added 4 commits May 6, 2024 17:27
@FabianPfeuffer @pmai
Improve omit_static_information field description
7d588c6 
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@bmw.de>
@FabianPfeuffer @pmai
Fixed minor spelling mistake
ffc2e8c 
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@bmw.de>
@thomassedlmayer @pmai
Mark OSMP as example for ground truth init
ce85f11 
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
@pmai
Grammar fix from review
8f99953 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai merged commit af8049b into OpenSimulationInterface:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomassedlmayer thomassedlmayer thomassedlmayer left review comments

@pmai pmai pmai approved these changes

@jdsika jdsika jdsika approved these changes

Assignees

@pmai pmai

Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FabianPfeuffer @jdsika @pmai @thomassedlmayer