Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add features for the combined release pipeline #63

Merged
merged 10 commits into from
Mar 31, 2023

Conversation

philipwindecker
Copy link
Contributor

@philipwindecker philipwindecker commented Jan 30, 2023

IMPORTANT: Remove local workarounds before merging!

Add a description

This PR adds a new pipeline that is triggered from the release pipeline in open-simulation-interface.
When triggered, it creates a new tag (identical to the one used for the release) and pushes it.

Mention a member

@pmai

Check the checklist

  • I have performed a self-review of my own code/documentation.
  • My documentation changes are related to another repository in the organization. Here is the link to the issue/repo.
  • My changes generate no new warnings during the documentation generation.
  • The existing travis ci which pushes the documentation to gh-pages passes with my changes.

Related PRs

@philipwindecker philipwindecker added the quality Quality improvements. label Jan 30, 2023
@philipwindecker philipwindecker changed the title Draft: Add features for the combined release pipeline Build: Add features for the combined release pipeline Jan 30, 2023
@philipwindecker philipwindecker self-assigned this Jan 30, 2023
@philipwindecker
Copy link
Contributor Author

IMPORTANT: Remove local workarounds before merging!

@philipwindecker
Copy link
Contributor Author

@pmai please review soon, otherwise we may get into time conflicts later.
There are still a couple of clean up steps I need to take after your review before we can merge, and likely I will have to do at least one test after merging to make sure everything works on here as it did on my forks.
Thanks!

philipwindecker and others added 2 commits March 27, 2023 12:04
@philipwindecker philipwindecker marked this pull request as ready for review March 27, 2023 10:17
@philipwindecker
Copy link
Contributor Author

@pmai please review soon, otherwise we may get into time conflicts later. There are still a couple of clean up steps I need to take after your review before we can merge, and likely I will have to do at least one test after merging to make sure everything works on here as it did on my forks. Thanks!

As dicussed in today's CCB meeting, I removed the workarounds pointing to forked repositories.
Changes can now be merged. Please add review so I can proceed, @pmai .

Note that I will need to confirm operation after merge to make sure all changes work as intended here as well.

Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as per CCB 2023-03-27.

@philipwindecker philipwindecker merged commit 8ca260f into OpenSimulationInterface:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants