Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Speaker Review: Typo in foreword.adoc #76

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

florianwallerer
Copy link
Contributor

@florianwallerer florianwallerer commented Jun 3, 2024

Add a description

Add a description of the changes proposed in the pull request.

Typo in foreword of OSI Documentation

Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
This is only a typo fix in a single adoc file, will not break anything.

Mention a member

Add @mentions of the person or team responsible for reviewing proposed changes.
@pmai & @dokuschmiede-aaren-mccall

Check the checklist

  • I have performed a self-review of my own code/documentation.
  • My documentation changes are related to another repository in the organization. Here is the link to the issue/repo.
  • My changes generate no new warnings during the documentation generation.
  • The existing travis ci which pushes the documentation to gh-pages passes with my changes.

@florianwallerer florianwallerer added documentation Everything which impacts the quality of the documentation and guidelines. ReadyForCCBReview labels Jun 3, 2024
@florianwallerer florianwallerer requested a review from pmai June 3, 2024 08:29
@florianwallerer florianwallerer changed the title Typo in foreword.adoc Native Speaker Review: Typo in foreword.adoc Jun 3, 2024
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-06-10: Merge as-is.

@pmai pmai merged commit c2bf773 into master Jun 10, 2024
1 check passed
@pmai pmai deleted the native-speaker-review_OSI_3.7.0 branch June 10, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants