remove meeting user_ids #2210
Closed
remove meeting user_ids #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
approved these changes
Apr 18, 2023
emanuelschuetze
requested changes
Apr 20, 2023
There was a problem hiding this comment.
If you remove meeting user_ids please remove also the particiapants number in meeting list view (if user is NOT allowed to see participants in meeting =! users.can_see).
For committee admins the field "Assigned accounts" in committee detail view can be removed - I think it was the reason for the meeting user_ids field.
Important: the client performance for new calculation of participant numbers has to be checked for meeting list and committee detail with hight participant numbers!
|
Diverged from main. If we still want to do this we should open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unlink pr and Issue #2107
Might need some testing especially if deleting and changing groups etc. still works. Currently only tested for participant list.