GitHub Actions file has leftovers from gettsim

[janosg]

This is as snippet from main.yml:

    steps:
      - uses: actions/checkout@v3
      - name: create build environment
        uses: mamba-org/provision-with-micromamba@main
        with:
          environment-file: environment.yml
          environment-name: "{{ cookiecutter.project_slug }}"
          cache-env: true
          extra-specs: |
            python=${{ matrix.python-version }}
      - name: run pytest
        shell: bash -l {0}
        run: |
          micromamba activate gettsim
          pytest --cov-report=xml --cov=./ --ignore=dashboard/
      - name: Upload coverage report.
        if: runner.os == 'Linux' && matrix.python-version == '3.11'
        uses: codecov/codecov-action@v3

It has at least 3 problems:

1. Once the cookiecutter.project_slug was not replaced
2. I tries to activate gettsim
3. The --ignore=dashboard/ is probably a leftover from gettsim

[janosg]

The problems were discovered in this project by @marvinsohn.

[hmgaudecker]

Thanks! Should be fixed in #135, though I do not understand the first point. Could you elaborate, @janosg @marvinsohn ?

[janosg]

Sure: environment-name: "{{ cookiecutter.project_slug }}" caused github actions to fail because it did not know how to replace cookiecutter.project_slug. I think this should be filled in by cookiecutter, i.e. the generated main.yml should have contained environment-name: option_pricing.

[hmgaudecker]

Ah, sure, cannot have that as GHA is using the same constructs as cookiecutter.

[janosg]

I think this environment name does not matter at all. Could be a fixed name like testenv if that is easier.

[hmgaudecker]

Yeah, I fixed it. Needs to be activated below, that's why it matters.