priorize rules depending on componen inheritance

src/graph/inheritance.ts

@@ -108,6 +108,17 @@ export default class Inheritance {
         return this.getTypes<RelationshipType>('relationship_types')[name]
     }
 
+    collectNodeTypes(name: string): {name: string; type: NodeType}[] {
+        const found: {name: string; type: NodeType}[] = []
+
+        const walker = this.Walker(name, 'node_types', NODE_TYPE_ROOT)
+        while (walker.has()) {
+            found.push(walker.walk())
+        }
+
+        return found
+    }
+
     private getTypes<T extends EntityType>(key: keyof EntityTypes) {
         return (this.graph.serviceTemplate[key] ?? {}) as {[key: string]: T}
     }

src/graph/type.ts

@@ -124,6 +124,10 @@ export default class Type extends Element {
         throw new Error(`${this.Display} does not support checking type inheritance`)
     }
 
+    getInheritance() {
+        // TODO: return inheritance
+    }
+
     getDefinition() {
         if (this.container.isArtifact()) {
             return this.graph.inheritance.getArtifactType(this.name)

src/technologies/plugins/rules/generators/software-application/tar-archive/asterisk/machine/local-machine/ansible/index.ts

@@ -15,7 +15,7 @@ class Generator extends GeneratorAbstract {
     technology = 'ansible'
     artifact = 'tar.archive'
     hosting = ['*', 'local.machine']
-    weight = 0.5
+    weight = 1
     reason =
         'While this is a primary use case due to the specialization of Ansible, we must rely on scripts. More specialized types should be used, e.g., service.application.'
 

src/technologies/plugins/rules/generators/software-application/tar-archive/asterisk/machine/remote-machine/ansible/index.ts

@@ -24,7 +24,7 @@ class Generator extends GeneratorAbstract {
     technology = 'ansible'
     artifact = 'tar.archive'
     hosting = ['*', 'remote.machine']
-    weight = 0.5
+    weight = 1
     reason =
         'While this is a primary use case due to the specialization of Ansible, we must rely on scripts. More specialized types should be used, e.g., "service.application".'
 

src/technologies/plugins/rules/generators/software-application/zip-archive/asterisk/machine/local-machine/ansible/index.ts

@@ -15,7 +15,7 @@ class Generator extends GeneratorAbstract {
     technology = 'ansible'
     artifact = 'zip.archive'
     hosting = ['*', 'local.machine']
-    weight = 0.5
+    weight = 1
     reason =
         'While this is a primary use case due to the specialization of Ansible, we must rely on scripts. More specialized types should be used, e.g., service.application.'
 

src/technologies/plugins/rules/generators/software-application/zip-archive/asterisk/machine/remote-machine/ansible/index.ts

@@ -24,7 +24,7 @@ class Generator extends GeneratorAbstract {
     technology = 'ansible'
     artifact = 'zip.archive'
     hosting = ['*', 'remote.machine']
-    weight = 0.5
+    weight = 1
     reason =
         'While this is a primary use case due to the specialization of Ansible, we must rely on scripts. More specialized types should be used, e.g., service.application.'
 

src/technologies/plugins/rules/index.ts

@@ -27,18 +27,18 @@ export class TechnologyRulePlugin implements TechnologyPlugin {
 
     getRules() {
         const rules = this.graph.serviceTemplate.topology_template?.variability?.technology_rules
-        if (check.isUndefined(rules)) return rules
+        if (check.isUndefined(rules)) return []
         assert.isObject(rules, 'Rules not loaded')
         return rules
     }
 
     hasRules() {
-        return check.isDefined(this.getRules())
+        return utils.isPopulated(this.getRules())
     }
 
     implement(name: string, type: NodeType): NodeTypeMap {
         const rules = this.getRules()
-        if (check.isUndefined(rules)) return {}
+        if (utils.isEmpty(rules)) return {}
 
         const types: NodeTypeMap = {}
 
@@ -94,18 +94,30 @@ export class TechnologyRulePlugin implements TechnologyPlugin {
         return types
     }
 
+    // TODO: rework this function
     assign(node: Node): TechnologyTemplateMap[] {
         const maps: TechnologyTemplateMap[] = []
 
-        const rules = this.getRules()
-        if (check.isUndefined(rules)) return maps
+        let rules = this.getRules()
+        if (utils.isEmpty(rules)) return maps
+
+        // Check if rule matches component
+        rules = rules.filter(rule => node.getType().isA(rule.component))
+
+        // Check if another rule is more specific, i.e., if rule.component is within the inheritance (but not the root) of another rule
+        rules = rules.filter(rule =>
+            check.isUndefined(
+                rules.find(other => {
+                    const parents = this.graph.inheritance.collectNodeTypes(other.component).slice(1)
+                    return check.isDefined(parents.find(type => type.name === rule.component))
+                })
+            )
+        )
 
         for (const entry of rules) {
             const rule = utils.copy(entry)
             assert.isDefined(rule.hosting)
 
-            if (!node.getType().isA(rule.component)) continue
-
             let artifactCondition: LogicExpression | undefined
             if (check.isDefined(rule.artifact)) {
                 // Check for artifact in template

tests/conformance/technologies/optimization-prio/expected.yaml

@@ -0,0 +1,14 @@
+tosca_definitions_version: tosca_simple_yaml_1_3
+
+node_types:
+    grandparent:
+        derived_from: tosca.nodes.Root
+    parent:
+        derived_from: grandparent
+    container:
+        derived_from: parent
+
+topology_template:
+    node_templates:
+        container:
+            type: container~parent::ansible

tests/conformance/technologies/optimization-prio/template.yaml

@@ -0,0 +1,25 @@
+tosca_definitions_version: tosca_variability_1_0_rc_3
+
+node_types:
+    grandparent:
+        derived_from: tosca.nodes.Root
+    parent:
+        derived_from: grandparent
+    container:
+        derived_from: parent
+
+topology_template:
+    variability:
+        technology_rules:
+            - component: parent
+              technology: ansible
+              weight: 0
+
+            - component: grandparent
+              technology: terraform
+              weight: 1
+
+    node_templates:
+        container:
+            type: container
+            persistent: true

tests/conformance/technologies/optimization-prio/test.yaml

@@ -0,0 +1 @@
+description: technology rule for grandparent is not considered since technology rule for parent is stricter