Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Alpha Vantage' ToS and PP declarations #1377

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented Mar 4, 2024

Both URLs respond with a PDF response => no selectors

Uses ?.pdf as a workaround for lint not supporting arbitrary URLs for PDFs

OpenTermsArchive/engine#900

@Kissaki
Copy link
Contributor Author

Kissaki commented Mar 4, 2024

The lint seems to fail because it requires an URL ending with .pdf - which is not the case and not possible here.

data/documents/Terms of Service should have required property 'select'
>     "Terms of Service": {
>       "fetch": "https://www.alphavantage.co/terms_of_service/"

data/documents/Terms of Service should NOT have additional properties
>     "Terms of Service": {
>       "fetch": "https://www.alphavantage.co/terms_of_service/"

data/documents/Terms of Service should have required property 'combine'
>     "Terms of Service": {
>       "fetch": "https://www.alphavantage.co/terms_of_service/"

data/documents/Terms of Service/fetch should match pattern "^https?://.+.[pP][dD][fF](\?.+)?$"
> 

data/documents/Terms of Service should match exactly one schema in oneOf
>     "Terms of Service": {
>       "fetch": "https://www.alphavantage.co/terms_of_service/"

@MattiSG
Copy link
Member

MattiSG commented Mar 4, 2024

Thanks @Kissaki! This is indeed a known limitation with PDF files that do not end with .pdf… The current workaround is to add the .pdf as a query string or anchor, as documented in OpenTermsArchive/engine#900.

Both URLs respond with a PDF response => no selectors

Uses `?.pdf` as a workaround for lint not supporting arbitrary URLs for PDFs

OpenTermsArchive/engine#900
@Kissaki
Copy link
Contributor Author

Kissaki commented Mar 4, 2024

I updated the code and commit accordingly

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MattiSG MattiSG merged commit 1f07f6f into OpenTermsArchive:main Mar 4, 2024
3 checks passed
@Kissaki Kissaki deleted the alphavantage branch March 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants