-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable searching courses by teacher name #142
Conversation
Also included a fix for #134. |
Resolved. |
Do I have to separate a new API for teacher name searching and use |
或许这样是更好的,不过需要前端适配两种不同的搜索模式。现在这样的策略对于用户来说,搜索 Teacher 但是显示 CourseGroup 感觉比较奇怪😂 |
Is there an advantage for using |
Maybe in this situation |
Regarding to changes merged in <OpenTreeHole/backend#142> PS: I believe this is too minor for a PR
Enable searching by teacher name on server side, resolves DanXi-Dev/DanXi#375.
In order to make the new code work, there are something changes to do on the database.
teacher
table (for the sake of query performance)teacher
andteacher_courses
fromcourse
Link: https://github.com/HydrogenC/backend/blob/teacher-name/danke_utils/teacher_table.go