Topic/eco stuff #1068
Merged
Topic/eco stuff #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| rslt = json.loads(urllib2.urlopen(url).read()) | ||
| except urllib2.HTTPError as e: | ||
| if e.fp.read() == 'invalid otm code for region\n': |
There was a problem hiding this comment.
Testing for a specific error message seems fragile. But the alternative (returning a JSON response object indicating success or failure, with details) comes down to the same thing -- both sides must agree on an interface and both sides need to change if the interface changes. This is simpler, and time is short...
There was a problem hiding this comment.
I really want to spend some time properly refactoring the go tiler. There is an issue out there for using http error codes instead which I'd like to support: OpenTreeMap/otm-ecoservice#11
|
+1 |
Fixes Eco Benefits Issue OpenTreeMap#13
Fixes OpenTreeMap#1061 In the future we may want to support using a 404 but that appears non-trivial with the go library we're using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.