Add eco_scenario.json endpoint to support modeling #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I factored some code out of the eco.json endpoint to keep things DRY. While moving the code I added more descriptive error messages for the different failure modes, to help with debugging. I renamed some of the generically named structures used for JSON marshaling so that they are more specific about their contents and the endpoints to which they are related.
|
It would be nice to see some unit tests for this new endpoint |
|
Otherwise it looks good, +1 |
|
I did not want to block the creation of this endpoint with the creation of an equally large functional test harness, so I made a separate issue (#25) to get the coverage up to snuff. |
jwalgran
added a commit
that referenced
this pull request
Jul 16, 2014
Add eco_scenario.json endpoint to support modeling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I factored some code out of the eco.json endpoint to keep things DRY. While moving the code I added more descriptive error messages for the different failure modes, to help with debugging.
I renamed some of the generically named structures used for JSON marshaling so that they are more specific about their contents and the endpoints to which they are related.