Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add GPU direct unit test #1002

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Tests: Add GPU direct unit test #1002

merged 10 commits into from
Oct 29, 2024

Conversation

PanKaker
Copy link
Collaborator

PR introduces:

  • Updated documentation of gpu direct library.
  • Unit test coverage.
  • Updated version of meson build with new option 'enable_tests' to enable unit test.
  • 'run_tests.sh' - script to build and run test

@PanKaker
feat(gpu_direct): Add new meson option 'enable_tests' to run unit tes…
af342e3 
…t. Update meson.build file. Update documentation of 'gpu_direct'. Add new unit tests to cover: 'gpu_allocate_shared_buffer', 'gpu_memcpy', 'gpu_memset' and 'free_gpu_context' functions
@PanKaker
doc: update naming of some tests
80c19d5
DawidWesierski4
DawidWesierski4 reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this as a separate entity from the rest of the tests ?
why not merge the tests to the existing tests framework ?

@PanKaker
Copy link
Collaborator Author

PanKaker commented Oct 29, 2024 •
edited
Loading

Should we keep this as a separate entity from the rest of the tests ? why not merge the tests to the existing tests framework ?

GPU direct is the separate library with separate scope, it's better to separate MTL tests and GPU direct tests.
Running GPU direct tests will be covered in another CI workflow file.

DawidWesierski4
DawidWesierski4 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PanKaker PanKaker merged commit b40e87a into OpenVisualCloud:main Oct 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidWesierski4 DawidWesierski4 DawidWesierski4 approved these changes

@Sakoram Sakoram Awaiting requested review from Sakoram Sakoram is a code owner

@skolelis skolelis Awaiting requested review from skolelis skolelis is a code owner

@Falron98 Falron98 Awaiting requested review from Falron98 Falron98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanKaker @DawidWesierski4