Fix: error handling in parsing sample freq in FFmpeg audio plugins #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 065923f ("Refactor FFmpeg audio plugin sample rate parsing") added a helper function for parsing the sample frequency. However, the error returned from the function was checked incorrectly (inverted). This led to a segmentation fault when starting FFmpeg with MTL audio plugins. This commit fixes the error handling by checking if the return value is non zero. Fixes: 065923f ("Refactor FFmpeg audio plugin sample rate parsing") Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com> Change-type: DefectResolution
ko80
requested review from
PanKaker,
DawidWesierski4,
Sakoram,
skolelis and
Falron98
as code owners
|
lgtm |
DawidWesierski4
changed the title
|
Just a small comment IMO its readable enough though |
DawidWesierski4
approved these changes
Sep 24, 2024
Agreed on using an appropriate style of commit messages in imperative mode in the future commits. This one goes as it is. |
PanKaker
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 065923f ("Refactor FFmpeg audio plugin sample rate parsing") added a helper function for parsing the sample frequency. However, the error returned from the function was checked incorrectly (inverted). This led to a segmentation fault when starting FFmpeg with MTL audio plugins.
This commit fixes the error handling by checking if the return value is non zero.
Fixes: 065923f ("Refactor FFmpeg audio plugin sample rate parsing")
Change-type: DefectResolution