correct the use of header in sample tx rtp app #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update st20 rtp header to rfc4175 in sample rtp app
weic6
requested review from
PanKaker,
DawidWesierski4,
Sakoram,
skolelis and
Falron98
as code owners
PanKaker
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct st20_rfc4175_rtp_hdris the correct one to use because:In function
app_tx_build_rtp_packet, payload is filled usingmemset(payload, 0, s->packet_size - sizeof(*rtp)), where rtp is of typestruct st20_rfc4175_rtp_hdr*, so inmain, the packet sizeops_tx.rtp_pkt_sizeshould be1200 + sizeof(struct st20_rfc4175_rtp_hdr)