-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #30 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 14
Lines ? 2558
Branches ? 0
=====================================
Hits ? 0
Misses ? 2558
Partials ? 0 |
'audio': BytesIO(byte_data), | ||
'metadata': StringIO(json.dumps(params)) | ||
} | ||
return self.post(upload_url, files=ww_files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mentioned the header problem earlier. we can not send any content_type
(if posted this way). The correct type will be chosen.
The files have to be sent as multipart/form-data
. The problem with that is that this type has a boundary extension associated (like Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryzuW5nPZQFQCwQtg4
), which is generated automatically by requests
, but not if we predefine it as multipart/form-data
Otherwise flask.request.files
has no clue what is sent and return an empty ImmutableMultiDict
This issue is about postman, but the same applies here
Annoying problem and more time spent on it than i care to admit. And i'd say toss this and post it like stt data
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a separate PR coordinated with a companion PR in personal backend (for both STT and WW)
readme pass credentials to base backend object optional OPM manual version bump - signal breaking change to accompany personal-backend new features fix headers fix license tests fix unittests consistency SkillSettingsApi for personal/selene cleanup DeviceApi/DatasetApi + add SkillSettingsApi fix Configuration.get (#32) SkillSettingsApi old Api classes deprecation logs cleanup skill settings model + missing DatasetApi - dataset_upload_stt_recording for consistency add DatabaseApi offline oauth CRUD offline backend - recording "upload" offline backend - recording "upload" offline backend - skill settings offline backend - ww/voice definitions cleanup json modules add some database endpoints for offline backend database api base undo location stuff and renaming migrate json db utils
companion to OpenVoiceOS/ovos-personal-backend#51
adds the new DatabaseApi for direct manipulations of databases, for offline backend this will manage relevant config files or use json databases
the json databases removed from backend were moved here, this package used to contain a reimplementation using json_database package directly