[Feature]: #1992 Add top, right, bottom, left alignment for CUIStatic #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohjimane
changed the title
yohjimane
force-pushed
the
enhancement/1192
branch
from
633cb6c to
89827b6
Compare
yohjimane
force-pushed
the
enhancement/1192
branch
from
89827b6 to
913fd0e
Compare
yohjimane
commented
May 19, 2023
| @@ -1058,32 +1058,62 @@ void CUIXmlInitBase::ApplyAlign(float& x, float& y, u32 align) | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| // source: https://stackoverflow.com/questions/650162/why-cant-the-switch-statement-be-applied-to-strings | |||
| constexpr uint32_t hash(const std::string_view data) noexcept | |||
There was a problem hiding this comment.
@Xottab-DUTY can you advise where to put this function? It can be used to refactor other large if statement blocks with strings -> switch cases.
There was a problem hiding this comment.
I didn't merged this PR in time only because I was thinking where to put this function, and then decided to think a bit later, and...
Just screw this "thinking". 😆 I'll just merge this, it's ok to keep this function here for now..
There was a problem hiding this comment.
Typically, this should be put somewhere in xrCore.
yohjimane
changed the title
yohjimane
changed the title
Xottab-DUTY
approved these changes
Oct 17, 2023
|
@Hrusteckiy, hurray! Ura!!! I really like this PR has 1337th number, hehe. |
|
I'm glad, will check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1192
Example:
Example code in ui_custom_msgs.xml: