Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate new public key in Account public key setter functions #818

Closed
martriay opened this issue Nov 10, 2023 · 0 comments · Fixed by #989 or #990
Closed

Validate new public key in Account public key setter functions #818

martriay opened this issue Nov 10, 2023 · 0 comments · Fixed by #989 or #990
Assignees
@ericnordelo
Labels
Account contract

Comments

@martriay
Copy link
Contributor

To minimize the risk of changing the key to a wrong one, there could be an impl in AccountComponent that validates ownership e.g. by requiring a signed message. It might make sense to standardize such message.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Dec 10, 2023
@martriay martriay modified the milestones: after, later Dec 10, 2023
@martriay martriay mentioned this issue Dec 10, 2023
Closed
@martriay martriay mentioned this issue Dec 10, 2023
Closed
@martriay martriay modified the milestones: later, after Jan 26, 2024
@martriay martriay modified the milestones: after, current Mar 4, 2024
@martriay martriay moved this from 📋 Backlog to 👀 In review in Contracts for Cairo Mar 4, 2024
@martriay martriay mentioned this issue Mar 4, 2024
Closed
@martriay martriay linked a pull request Mar 4, 2024 that will close this issue
Verify signer control on setPublicKey #922
Closed
@martriay martriay self-assigned this Mar 4, 2024
@martriay martriay removed their assignment Mar 21, 2024
@martriay martriay modified the milestones: 0. current, 2. after Mar 21, 2024
@andrew-fleming andrew-fleming modified the milestones: 2. next, 1. current Apr 30, 2024
@ericnordelo ericnordelo changed the title Should Account preset validate new public key? Validate new public key in Account public key setter functions May 14, 2024
@ericnordelo ericnordelo mentioned this issue May 14, 2024
Merged
4 tasks
@ericnordelo ericnordelo self-assigned this May 14, 2024
@ericnordelo ericnordelo mentioned this issue May 15, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Resolved in Contracts for Cairo May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
Account contract
Projects
Contracts for Cairo
Status: ✅ Resolved
Milestone
No milestone
3 participants
@martriay @ericnordelo @andrew-fleming