Make the Account setPublicKey function a two-steps process

[ericnordelo]

cairo-contracts/src/openzeppelin/account/presets/Account.cairo

Lines 47 to 53 in b764660

	@external
	func setPublicKey{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
	newPublicKey: felt
	) {
	Account.set_public_key(newPublicKey);
	return ();
	}

This method can make the contract unusable if a wrong public key is set by mistake. Maybe it would be good to add a two steps process allowing to claim the new public key before removing the old one? (Similar to the two-step ownership transfer process in Solidity contracts).

Also applies for setEthAddress in EthAccount.cairo:

cairo-contracts/src/openzeppelin/account/presets/EthAccount.cairo

Lines 45 to 51 in b764660

	@external
	func setEthAddress{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
	newEthAddress: felt
	) {
	Account.set_public_key(newEthAddress);
	return ();
	}

[martriay]

What about an optimization: make it a single tx that takes the incoming pubkey's new signature to validate the process.

[martriay]

Apparently I suggested that already 😅: #818

[TAdev0]

@martriay may i work on this issue?

[martriay]

Same as #21 (comment), let's focus on the ongoing ones first.

[ericnordelo]

Closing in favor of #818