Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC721ABI and fix other abis #761

Merged
merged 23 commits into from
Nov 27, 2023
Merged

Add ERC721ABI and fix other abis #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3b6a08c
fix account abi
andrew-fleming Sep 29, 2023
e663320
fix erc20 abi
andrew-fleming Sep 29, 2023
5471a7d
fix erc721 abi
andrew-fleming Sep 29, 2023
79b044d
reorder internal fns
andrew-fleming Sep 29, 2023
fc3872b
reorder internal fns
andrew-fleming Sep 29, 2023
2d279a0
fix comment
andrew-fleming Sep 29, 2023
300723f
reorder fns
andrew-fleming Oct 2, 2023
605e454
fix casing
andrew-fleming Oct 2, 2023
9c2c16d
fix casing
andrew-fleming Oct 2, 2023
71b2bea
reorder api fns
andrew-fleming Oct 2, 2023
b00c017
add dual interfaces link
andrew-fleming Oct 2, 2023
278ccc4
add camel methods to api
andrew-fleming Oct 3, 2023
74d053c
remove imports
andrew-fleming Oct 3, 2023
e11811a
re-add src5_state
andrew-fleming Oct 3, 2023
9de416c
fix conflicts
andrew-fleming Oct 3, 2023
25b2dd8
Apply suggestions from code review
andrew-fleming Oct 6, 2023
05c7936
add deployer trait/impl
andrew-fleming Oct 9, 2023
e154354
change non-standard to impls in fn list
andrew-fleming Oct 9, 2023
f0a1673
fix in-code doc style
andrew-fleming Oct 10, 2023
50038b4
fix comments
andrew-fleming Oct 10, 2023
0e2199a
fix conflicts
andrew-fleming Nov 26, 2023
f3cf6af
fix interface order
andrew-fleming Nov 27, 2023
f9bb313
remove unused impl
andrew-fleming Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/accounts.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:test-signers: https://github.com/OpenZeppelin/cairo-contracts/blob/release-v0.6.1/tests/signers.py
:snip-5: https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-5.md
:snip-6: https://github.com/ericnordelo/SNIPs/blob/feat/standard-account/SNIPS/snip-6.md
:counterfactual: xref:/guides/deployment.adoc[Counterfactual deployments]
:counterfactual: xref:/guides/deployment.adoc[counterfactual deployments]

= Accounts

Expand Down
10 changes: 5 additions & 5 deletions src/account/interface.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ trait ISRC6<TState> {
fn is_valid_signature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait ISRC6CamelOnly<TState> {
fn isValidSignature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait IDeclarer<TState> {
fn __validate_declare__(self: @TState, class_hash: felt252) -> felt252;
Expand All @@ -36,6 +31,11 @@ trait IPublicKey<TState> {
fn set_public_key(ref self: TState, new_public_key: felt252);
}

#[starknet::interface]
trait ISRC6CamelOnly<TState> {
fn isValidSignature(self: @TState, hash: felt252, signature: Array<felt252>) -> felt252;
}

#[starknet::interface]
trait IPublicKeyCamel<TState> {
fn getPublicKey(self: @TState) -> felt252;
Expand Down