Remove duplicated SLOAD in Arrays.findUpperBound (#4442)

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com> Co-authored-by: Francisco Giordano <fg@frang.io>
OpenZeppelin · Jul 12, 2023 · 0abf18f · 0abf18f
1 parent 921ac49
commit 0abf18f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/fluffy-countries-buy.md b/.changeset/fluffy-countries-buy.md
@@ -0,0 +1,5 @@
+---
+'openzeppelin-solidity': minor
+---
+
+`Arrays`: Optimize `findUpperBound` by removing redundant SLOAD.
diff --git a/contracts/utils/Arrays.sol b/contracts/utils/Arrays.sol
@@ -22,13 +22,13 @@ library Arrays {
      * repeated elements.
      */
     function findUpperBound(uint256[] storage array, uint256 element) internal view returns (uint256) {
-        if (array.length == 0) {
-            return 0;
-        }
-
         uint256 low = 0;
         uint256 high = array.length;
 
+        if (high == 0) {
+            return 0;
+        }
+
         while (low < high) {
             uint256 mid = Math.average(low, high);