Skip to content

Commit

Permalink
Add missing return value names in IAccessManager (#4829)
Browse files Browse the repository at this point in the history
Co-authored-by: Ernesto García <ernestognw@gmail.com>
  • Loading branch information
bxmmm1 and ernestognw authored Jan 12, 2024
1 parent a4b98bc commit 920225a
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions contracts/access/manager/IAccessManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,16 @@ interface IAccessManager {
* [2] Pending execution delay for the account.
* [3] Timestamp at which the pending execution delay will become active. 0 means no delay update is scheduled.
*/
function getAccess(uint64 roleId, address account) external view returns (uint48, uint32, uint32, uint48);
function getAccess(
uint64 roleId,
address account
) external view returns (uint48 since, uint32 currentDelay, uint32 pendingDelay, uint48 effect);

/**
* @dev Check if a given account currently has the permission level corresponding to a given role. Note that this
* permission might be associated with an execution delay. {getAccess} can provide more details.
*/
function hasRole(uint64 roleId, address account) external view returns (bool, uint32);
function hasRole(uint64 roleId, address account) external view returns (bool isMember, uint32 executionDelay);

/**
* @dev Give a label to a role, for improved role discoverability by UIs.
Expand Down Expand Up @@ -340,7 +343,11 @@ interface IAccessManager {
* this is necessary, a random byte can be appended to `data` to act as a salt that will be ignored by the target
* contract if it is using standard Solidity ABI encoding.
*/
function schedule(address target, bytes calldata data, uint48 when) external returns (bytes32, uint32);
function schedule(
address target,
bytes calldata data,
uint48 when
) external returns (bytes32 operationId, uint32 nonce);

/**
* @dev Execute a function that is delay restricted, provided it was properly scheduled beforehand, or the
Expand Down

0 comments on commit 920225a

Please sign in to comment.