-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CREATE2 contract factory #1644
Comments
Here is a nice example of a factory by @miguelmota, based on @stanislaw-glogowski's code: |
I think there are two types of CREATE2 factories one might want to consider:
There is a significant difference in implementation, interface, and security, so I created a separate ticket for that #1651 |
It may also be possible to have the factory contract in #1651 extend a base contract that only has |
Ive been playing with CREATE2, taking this issue, going to submit a PR with a simple CREATE2 factory. Later we can extend it to a factory with meta txs support. |
@AugustoL keep an eye on the proxy factory we built for zOS, we could reuse some of that code. |
We have this in a feature branch with some pending work. See #2013. |
As discussed with @cwhinfrey, @jamesyoung and @spalladino, it'd be interesting to include a factory such as archanova's (by @stanislaw-glogowski, which uses CREATE2, making it possible to predict the contract's address) into OpenZeppelin, possibly expanding upon it to cover more use cases.
One aspect in particular I'd like to discuss is constructor arguments: the linked implementation has a fixed bytecode, but it shouldn't be too difficult to come up with a scheme where these initial values are injected.
The text was updated successfully, but these errors were encountered: