Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create2 feature pending tasks #2013

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Create2 feature pending tasks #2013

merged 5 commits into from
Jan 23, 2020

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Dec 2, 2019 •
edited
Loading

This PR tracks the tasks pending to merge feature-create2, introduced in #1744.
Fixes #1644

Pull requests are accepted!

  • Consider alternative names that are maybe more descriptive.
  • Add a revert reason when the deploy fails.

@frangio
Add Create2 library (#1744)
970f687 
* feat(contracts): Add Create2 library to use create2 evm opcode

* Upgrade sol-coverage

* Add changelog entry

* Update comments and code style

* Remove create2 helper

* Fix linter error

* Fix truffle dependency

* Fix linter error

* refactor(Create2): Remove _deploy internal function

* test(Create2): test Create2 with inline assembly code

* fix(Create2): Check address returned form create2 instead of codesize of created contract
@frangio
Copy link
Contributor Author

frangio commented Dec 4, 2019

Consider alternative names that are maybe more descriptive.

We're keeping Create2 with the argument of familiarity: even though it's a bad name, it's the name of the underlying opcode CREATE2: developers may already be familiar with it, there is certainly a lot of material about it online, and it will be easier to find this library if the name is Create2.

@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the stale label Dec 19, 2019
@frangio frangio added meta and removed stale labels Dec 19, 2019
@frangio frangio mentioned this pull request Jan 20, 2020
Closed
@AugustoL
Copy link
Contributor

Going to add the revert reason when deploy fails.

@AugustoL AugustoL mentioned this pull request Jan 21, 2020
Merged
@nventuro nventuro marked this pull request as ready for review January 23, 2020 18:05
@nventuro
Copy link
Contributor

Thanks everyone for your work! 🎉

@nventuro nventuro merged commit 8c40a5b into master Jan 23, 2020
@nventuro nventuro deleted the feature-create2-2 branch January 23, 2020 18:09
KaiRo-at pushed a commit to KaiRo-at/openzeppelin-contracts that referenced this pull request Mar 16, 2020
@frangio @KaiRo-at
Create2 feature pending tasks (OpenZeppelin#2013)
88f3601 
* Add Create2 library (OpenZeppelin#1744)

* feat(contracts): Add Create2 library to use create2 evm opcode

* Upgrade sol-coverage

* Add changelog entry

* Update comments and code style

* Remove create2 helper

* Fix linter error

* Fix truffle dependency

* Fix linter error

* refactor(Create2): Remove _deploy internal function

* test(Create2): test Create2 with inline assembly code

* fix(Create2): Check address returned form create2 instead of codesize of created contract

* refactor(Create2):Add revert reason when Create2 deploy fails (OpenZeppelin#2062)

* fix merge with master

* fix test

Co-authored-by: Augusto Lemble <me@augustol.com>
@frangio frangio mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CREATE2 contract factory
3 participants
@frangio @AugustoL @nventuro