-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change crowdsales to use timestamps instead of block numbers #350
Comments
…elin#350 update derived crowdsales
Some thoughts from my end (cross post from Slack)
|
Change crowdsales to use timestamps instead of block numbers #350
Thank you for your thoughts @SCBuergel. I agree with all of them. We have done the change (#353) because of the disdvantage you stated, and the reasoning that it's a good trade-off for crowdsales. I'll recap this in the release notes. |
…elin#350 update derived crowdsales
Finally. Months ago I reported that the ethereum team members had agreed that a block time could not be gamed by more than a few seconds. Certainly not the 15 minutes mentioned above. The original comment was to prevent it being used for things like rand seeds. |
…e timestamps instead of block numbers (see OpenZeppelin/openzeppelin-contracts#350)
…elin#350 update derived crowdsales
Change crowdsales to use timestamps instead of block numbers OpenZeppelin#350
Due to the difficulty bomb it is very hard to estimate block numbers.
The text was updated successfully, but these errors were encountered: