Update the use of call() with selector only. #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
callAndHash
branch
2 times, most recently
from
a15fcd5
to
704356d
Compare
axic
commented
Jun 20, 2018
| @@ -5,7 +5,7 @@ contract ReentrancyAttack { | |||
|
|
|||
| function callSender(bytes4 data) public { | |||
| // solium-disable-next-line security/no-low-level-calls | |||
| require(msg.sender.call(data)); | |||
| require(msg.sender.call(abi.encodeWithSelector(data))); | |||
There was a problem hiding this comment.
call will enforce a single bytes argument, this way it will still work properly.
axic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
This is a backwards compatible update for Solidity 0.5.0, see ethereum/solidity#4097