Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle ERC20Detailed #2161

Merged
merged 10 commits into from
Apr 2, 2020
Merged

Bundle ERC20Detailed #2161

merged 10 commits into from
Apr 2, 2020

Conversation

nventuro
Copy link
Contributor

Part of #2086

This is the ERC20 counterpart of #2149. Like in the case of ERC721, the derived contracts were made abstract.

I also had to fix some Create2 tests that relied on ERC20 having no constructor.

@nventuro nventuro requested a review from frangio March 30, 2020 18:51
frangio
frangio reviewed Mar 30, 2020
View reviewed changes
contracts/token/ERC20/ERC20.sol Outdated Show resolved Hide resolved
contracts/token/ERC20/ERC20Burnable.sol Show resolved Hide resolved
@nventuro nventuro requested a review from frangio April 1, 2020 21:40
frangio
frangio previously approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but the idea of having constructor only functions like _setupDecimals or _setupRole is really new, and it would be good to get the opinion of someone else.

frangio
frangio reviewed Apr 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nventuro @frangio
Update CHANGELOG.md
cce340f 
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
@nventuro nventuro merged commit 0408e51 into OpenZeppelin:master Apr 2, 2020
@nventuro nventuro deleted the erc20-bundling branch April 2, 2020 18:30
@nventuro nventuro mentioned this pull request Apr 3, 2020
Merged
@ernestognw ernestognw mentioned this pull request Jan 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio