-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some private functions internal to allow the developpement of "withSignature" functions (like permit) #2568
Conversation
Being discussed in #2567. |
92d2b29
to
9b9dab3
Compare
9b9dab3
to
2afb5f8
Compare
…in-contracts into feature/internalSetOwner
Sorry to come back to this but I have one remaining concern. At some point we thought it was not such a good idea to have a single underscore determine such different semantics. I think we should try to have different names... the name |
I personally think that a prefix underscore is clearly a mark of "this is internal, with no access check". We already use this pattern in a lot of contracts, particularly |
This comment was marked as spam.
This comment was marked as spam.
Hello @Mehduzza420 This is not the place for this question. You should try your wallet's community channel. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@Mehduzza420 Please open a new issue if needed. |
Fixes #2567
PR Checklist