Add a SafeERC20:safePermit function #3280

Amxx · 2022-03-22T14:45:05Z

Note: IMO it would be slightly better to use abi.encodeCall instead of abi.encodeWithSelector, but that would require a bump to 0.8.11

CHANGELOG.md

contracts/mocks/SafeERC20Helper.sol

contracts/token/ERC20/extensions/draft-IERC20Permit.sol

contracts/token/ERC20/utils/SafeERC20.sol

test/token/ERC20/utils/SafeERC20.test.js

Co-authored-by: Francisco <frangio.1@gmail.com>

Add a SafeERC2O:safePermit function

8d47aa6

Amxx changed the title ~~Add a SafeERC2O:safePermit function~~ Add a SafeERC20:safePermit function Mar 22, 2022

use nonce tracking to check permit success

40b5a46

Amxx marked this pull request as draft March 28, 2022 15:56

Amxx added 4 commits June 6, 2022 11:44

IERC20Permit should extend IERC20 as described in the ERC

66db182

Merge branch 'master' into feature/ERC20/safePermit

68f7f82

add safePermit tests

c13a930

add Changelog entry

c0cf61b

Amxx marked this pull request as ready for review June 6, 2022 10:54

move Permit type definition to single place

2d21d7c

frangio reviewed Jun 6, 2022

View reviewed changes

Amxx and others added 3 commits June 7, 2022 08:28

Update CHANGELOG.md

4fa970e

Co-authored-by: Francisco <frangio.1@gmail.com>

address comments for the PR

fd72798

Update draft-IERC20Permit.sol

048c2b6

frangio previously approved these changes Jun 7, 2022

View reviewed changes

refactor SafeERC20 safePermit tests

f0b6fc4

Amxx dismissed frangio’s stale review via f0b6fc4 June 7, 2022 13:48

use different variable for signature

d0ab2dc

Amxx enabled auto-merge (squash) June 7, 2022 14:00

frangio approved these changes Jun 7, 2022

View reviewed changes

Amxx merged commit 7c75b8a into OpenZeppelin:master Jun 7, 2022

Amxx deleted the feature/ERC20/safePermit branch June 7, 2022 15:23

Provide feedback