Use unchecked arithmetic in "_transfer" and "_mint" #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @PaulRBerg for the PR. Can you please make sure the linter pass? You can run |
|
Also, It would be great to run the |
|
Sorry for that, I fixed the linting now. Here's the gas comparison below. Looks like both Before
After
|
Amxx
previously approved these changes
Jun 30, 2022
|
Could you also use a small changelog entry please? |
|
Done, ser. |
|
I added comments explaining why we can use |
frangio
approved these changes
Jul 1, 2022
Amxx
approved these changes
Jul 1, 2022
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
mmsqe
added a commit
to crypto-org-chain/cronos
that referenced
this pull request
Apr 18, 2023
for more info, see OpenZeppelin/openzeppelin-contracts#3513
yihuang
pushed a commit
to crypto-org-chain/cronos
that referenced
this pull request
Apr 18, 2023
…s/contracts (#979) * Bump @openzeppelin/contracts in /integration_tests/contracts Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 4.7.3 to 4.8.3. - [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases) - [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.8.3/CHANGELOG.md) - [Commits](OpenZeppelin/openzeppelin-contracts@v4.7.3...v4.8.3) --- updated-dependencies: - dependency-name: "@openzeppelin/contracts" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * adjust to 136 cheaper gas for more info, see OpenZeppelin/openzeppelin-contracts#3513 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3512.
There are no tests to write for this change.