Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues caused by abi.decode reverting #3552

Merged
merged 7 commits into from
Jul 18, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 15, 2022

The transition for 0.7.0 to 0.8.0 include a behavior changed that was missed.
Since 0.8.0, abi.decode reverts if the bytes raw data overflow the target type.

This PR fixes unexpected reverts for

  • SignatureChecker.isValidSignatureNow
  • ERC165Checker.supportsERC165InterfaceUnchecked

PR Checklist

  • Tests
  • Changelog entry

@frangio frangio enabled auto-merge (squash) July 18, 2022 20:50
@frangio frangio merged commit 628a6e2 into OpenZeppelin:master Jul 18, 2022
frangio pushed a commit that referenced this pull request Jul 19, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
(cherry picked from commit 628a6e2)
@Amxx Amxx deleted the fix/SignatureChecked branch July 27, 2022 21:12
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@OpenZeppelin OpenZeppelin deleted a comment from trevpeace Feb 28, 2024
@OpenZeppelin OpenZeppelin deleted a comment from trevpeace Feb 28, 2024
@OpenZeppelin OpenZeppelin deleted a comment from trevpeace Feb 28, 2024
@OpenZeppelin OpenZeppelin deleted a comment from trevpeace Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants