-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of historical quorum values #3561
Conversation
Waiting until next week to discuss a more efficient fix. |
The issue with this PR is that it increases the cost of voting when the PreventLateQuorum module is used. It seems like this can be fixed by first checking if the latest checkpoint is the one we're looking for (in |
I've implemented an optimistic lookup, that skips the binary search if the checkpoint we are looking for is the last one. However that only concerns
The |
Not, the parts not covered are mechanism used in cases of migration. |
Co-authored-by: Francisco Giordano <frangio.1@gmail.com> (cherry picked from commit 8ea1fc8)
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Checkpointing quorum is necessary to avoid quorum changes making old, failed because of quorum, proposals suddenly successful.
PR Checklist