-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Checkpoints with new sizes and lookup mechanisms #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
commented
Jul 28, 2022
Uses ethereum/solidity#9117 (comment) to skip checks |
3 tasks
frangio
reviewed
Aug 17, 2022
frangio
changed the title
Refactor the Checkpoint library, with new key/value balances and new lookup mechanisms
Extend Checkpoints with new sizes and lookup mechanisms
Aug 30, 2022
frangio
reviewed
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments. We can merge after this.
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
frangio
approved these changes
Aug 30, 2022
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes quite a few things:
Checkpoints.Checkpoint224
: key is uint32 and value is uint224. Usecase: history checkpoints for votingCheckpoints.Checkpoint160
: key is uint96 and value is uint160. Usecase: Address sequence (for NFT batch minting)latest()
push(key, value)
lowerLookup(key)
: returns thec.value
of the first checkpoint for whichkey <= c.key
(or 0 if no such checkpoint exists)upperLookup(key)
: returns thec.value
of the last checkpoint for whichkey >= c.key
(or 0 if no such checkpoint exists)upperLookupRecent(key)
: same asupperLookup
but optimised to look in recent checkpoints.Checkpoint.History
now uses theCheckpoints.Checkpoint224
structure, with block.number for keys.→ delayed to further PRgetAtBlock
now usesupperLookupRecent
, optimizing for recent value lookupFixes #3585
PR Checklist