Add internal functions _getInitializedVersion and _isInitializing
#3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @hrik2001 for this PR. We'll need tests and a changelog entry. Otherwize looks good |
frangio
changed the title
_getInitializedVersion and _isInitializing as required by #3584_getInitializedVersion and _isInitializing
|
@Amxx Hi! I have made changes accordingly (tests and changelog). Although some tests are failing. Is that worrying? Do let me know if I have to make more changes. Thank you! |
|
@Amxx oops, my bad, looks like all the tests have passed and I might have looked at the old test results. Please let me know your review and sorry for sounding like a broken record 😅 |
frangio
changed the title
_getInitializedVersion and _isInitializing_getInitializedVersion and _isInitializing
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3584
@frangio, once you are okay with this. I would add the functions in
InitializableMock.solSingleInheritanceInitializableMock.solMultipleInitializableMock.soland write tests accordingly. Pardon me if I have messed up something since I am a novice.PR Checklist