Remove unnecessary virtual #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this contract is not intended to be subclassed
This was referenced Aug 26, 2022
|
Thank you @fulldecent. Our automated changelog check is a little simple and this was a false positive since it's not a user facing change. Can you remove the changelog entry? |
|
@frangio cool, all done, other checks passed |
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 OpenZeppelin Contracts Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary
virtualin all mock contracts where those mocks are not intended to be subclassed.This reduces unnecessary surface area of those mocks and also reduces the risk of somebody seeing those mocks and thinking they are intended to be subclassed.