Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IERC4906 interface and use in ERC721 #4012

Merged
merged 9 commits into from
Feb 17, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 30, 2023

EIP is final: https://eips.ethereum.org/EIPS/eip-4906

PR Checklist

  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

🦋 Changeset detected

Latest commit: 31119cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frangio frangio added this to the 4.9 milestone Feb 16, 2023
@frangio frangio changed the title Add IERC4906 interface Add IERC4906 interface and use in ERC721 Feb 16, 2023
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a changeset for ERC721URIStorage. LGTM.

@Amxx Amxx enabled auto-merge (squash) February 17, 2023 09:08
@Amxx Amxx merged commit 96a2297 into OpenZeppelin:master Feb 17, 2023
@pcaversaccio
Copy link
Contributor

Hey, maybe am wrong here but I was just going through these changes - one question: shouldn't you add a test here as well? I noted that the interface ID 0x49064906 for IERC4906 is kinda special since it does not have any functions (not sure how it was calculated, maybe you know?), so makeInterfaceId wouldn't work.

@Amxx
Copy link
Collaborator Author

Amxx commented Feb 17, 2023

That is a good point. In fact in ERC721Storage we did not add ERC165 support for 0x49064906.

@Amxx Amxx deleted the interfaces/erc/4906 branch February 17, 2023 14:18
@pcaversaccio
Copy link
Contributor

Right, btw I quickly asked about the interfaceId and it was chosen randomly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants