Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return data length >= 32 in SignatureChecker #4038

Merged

Conversation

HarshitSharma007
Copy link
Contributor

@HarshitSharma007 HarshitSharma007 commented Feb 9, 2023

Used >=32 instead of ==32 in SignatureChecker for return data length check

Fixes #4035

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Used  >=32 instead of ==32 in SignatureChecker for return data length check
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023

🦋 Changeset detected

Latest commit: 13ec8e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Amxx
Amxx previously approved these changes Feb 24, 2023
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

need @frangio review

frangio
frangio previously approved these changes Feb 24, 2023
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio dismissed their stale review February 24, 2023 14:36

needs changeset

@frangio frangio changed the title Update SignatureChecker.sol Allow return data length >= 32 in SignatureChecker Feb 24, 2023
frangio
frangio previously approved these changes Feb 24, 2023
Amxx
Amxx previously approved these changes Feb 24, 2023
@frangio frangio enabled auto-merge (squash) February 24, 2023 14:44
@frangio frangio dismissed stale reviews from Amxx and themself via 13ec8e9 February 24, 2023 14:46
@frangio frangio merged commit b4d765b into OpenZeppelin:master Feb 24, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Feb 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use >=32 instead of ==32 in SignatureChecker for return data length check
3 participants