-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative fix for the TransparentUpgradeableProxy "decoding" bug #4168
Alternative fix for the TransparentUpgradeableProxy "decoding" bug #4168
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this alternative with Seppi and his main concern was related to extensibility. I don't think we should expect issues with overriding (agree they shouldn't be frequent and not recommended), but any modification to this contract will face the issue of needing to mine a clashing selector.
I share the same concern for legitimate possible use cases.
In my view, this is not something that is introduced by this PR, it's just implied by the transparency requirement. The alternative is #4154, which makes extending the proxy a little more cumbersome. |
I've updated the docs a little, with a focus on how they appear in the site. |
Partly revert and replace #4154.
This alternative fix is motivated by the goal to make more localized changes, since #4154 is a larger refactor.
Since the first commit in this PR is a revert of 5523c14 (#4154), it's better to see the diff against its parent.