-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TransparentUpgradeableProxy
admin immutable
#4354
Merged
ernestognw
merged 18 commits into
OpenZeppelin:master
from
ernestognw:lib-805-transparent-proxy-immutable-admin
Jun 20, 2023
Merged
Make TransparentUpgradeableProxy
admin immutable
#4354
ernestognw
merged 18 commits into
OpenZeppelin:master
from
ernestognw:lib-805-transparent-proxy-immutable-admin
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57e6869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
changed the title
Make
Make Jun 15, 2023
TransparentUpgradeableProxy
TransparentUpgradeableProxy
admin immutable
ernestognw
requested review from
frangio and
Amxx
and removed request for
frangio
June 15, 2023 18:58
ernestognw
commented
Jun 15, 2023
Amxx
reviewed
Jun 15, 2023
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx
reviewed
Jun 15, 2023
frangio
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
test/proxy/transparent/TransparentUpgradeableProxy.behaviour.js
Outdated
Show resolved
Hide resolved
test/proxy/transparent/TransparentUpgradeableProxy.behaviour.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Francisco <fg@frang.io>
Amxx
reviewed
Jun 16, 2023
Amxx
reviewed
Jun 16, 2023
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
ernestognw
commented
Jun 16, 2023
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2638
Fixes LIB-805
PR Checklist
npx changeset add
)