-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getRoleMembers method to return all accounts that have role #4546
Merged
ernestognw
merged 5 commits into
OpenZeppelin:master
from
vlad-khramov:add_getRoleMembers_method
Jan 4, 2024
Merged
Add getRoleMembers method to return all accounts that have role #4546
ernestognw
merged 5 commits into
OpenZeppelin:master
from
vlad-khramov:add_getRoleMembers_method
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c405a44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
previously approved these changes
Dec 19, 2023
ernestognw
previously approved these changes
Dec 19, 2023
ernestognw
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Amxx
approved these changes
Jan 4, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccessControlEnumerable
usesAddressSet
for storing accounts that have certain role.AddressSet
has very convenient methodvalues
to return all elements of the set, but it wan't used inAccessControlEnumerable
.Since
values
is recommened to use only in view calls, original warning was also added to documentation ofgetRoleMembers
methodPR Checklist
npx changeset add
)