Make AccessManager.execute/schedule more conservative when delay is 0 #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 42e8a1a)
🦋 Changeset detectedLatest commit: 1872a4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
previously approved these changes
Oct 2, 2023
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'openzeppelin-solidity': major | |||
There was a problem hiding this comment.
Not sure if it's major, isn't a patch although we're in pre-release?
There was a problem hiding this comment.
I don't know, wasn't sure what to choose. In theory this is a breaking change, that's why I chose major. I don't think it will make any difference to the release process.
There was a problem hiding this comment.
Ok make sense, also make sure it'll be picked up by the changeset versioning, which I think it will
|
The skip wasn't correctly written. |
This was referenced Sep 10, 2024
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
schedulefunction revert when the caller does not have an enforced delay. Note that this doesn't prevent a situation where a caller is able to schedule a call but later has their delay removed. To make that case more consistent with the normal schedule/execute case, this PR also makesscheduleconsume an available schedule even when the caller doesn't have a currently enforced delay, and correctly return the corresponding nonce which is important forGovernorTimelockAccess.Cherry picked from #4613, where tests were adjusted.