Add view modifier to proxyAdmin in TransparentUpgradeableProxy
#4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45fa1a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericglau
previously approved these changes
Oct 16, 2023
ericglau
previously approved these changes
Oct 16, 2023
Co-authored-by: Eric Lau <ericglau@outlook.com>
Amxx
approved these changes
Oct 17, 2023
ernestognw
added a commit
to ernestognw/openzeppelin-contracts
that referenced
this pull request
Oct 26, 2023
…penZeppelin#4688) Co-authored-by: Eric Lau <ericglau@outlook.com>
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing an audit recommendation to allow anyone to select their proxy admin if they decide to override it, the
_proxyAdmin()getter remained nonview.This is technically breaking but I don't see anyone complaining about that. The breaking change is that state updates are no longer allowed within an overriden
_proxyAdmin().PR Checklist
npx changeset add)