Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AccessControl tests #4694

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Migrate AccessControl tests #4694

merged 11 commits into from
Oct 26, 2023

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Oct 20, 2023 •
edited
Loading

Similar to #4689 and #4657.
Tests were migrated to ethers, although time durations were added to /helpers/time.js in favor of avoiding @openzeppelin/test-helpers usage

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a148ef2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw mentioned this pull request Oct 23, 2023
Closed
@ernestognw ernestognw requested a review from Amxx October 23, 2023 22:19
@ernestognw ernestognw added this to the tests migration milestone Oct 23, 2023
Amxx
Amxx approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some improvements.

@ernestognw if they are of by you, feel free to merge. Otherwise, lets discuss

@ernestognw
Copy link
Member Author

Made some improvements.

@ernestognw if they are of by you, feel free to merge. Otherwise, lets discuss

Looking sweet, thanks!

@ernestognw ernestognw merged commit 2ec2ed9 into OpenZeppelin:master Oct 26, 2023
13 checks passed
ernestognw added a commit to ernestognw/openzeppelin-contracts that referenced this pull request Oct 26, 2023
@ernestognw @Amxx
Migrate AccessControl tests (OpenZeppelin#4694)
bb2bcf8 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw mentioned this pull request Oct 29, 2023
Merged
3 tasks
@ernestognw ernestognw added the tests Test suite and helpers. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Milestone
tests migration
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestognw @Amxx