Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor supports interface #4817

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Refactor supports interface #4817

merged 2 commits into from
Jan 12, 2024

Conversation

RenanSouza2
Copy link
Contributor

This pr includes the ERC165 test by default in all shouldSupportInterfaces calls

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 85c645f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw added tests Test suite and helpers. ignore-changeset labels Jan 4, 2024
ernestognw
ernestognw previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool finding, thanks @RenanSouza2!

@ernestognw ernestognw requested a review from Amxx January 9, 2024 22:02
@ernestognw
Copy link
Member

Thanks @RenanSouza2!

@ernestognw ernestognw merged commit e68720e into OpenZeppelin:master Jan 12, 2024
18 checks passed
@RenanSouza2 RenanSouza2 deleted the tests-erc165-refactor branch January 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RenanSouza2 @ernestognw @Amxx