Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ERC721 and ERC1155 receiver checks to dedicate libraries #4845

Merged
merged 11 commits into from
Jan 30, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 18, 2024

Fixes LIB-1194

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: ed00c2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx requested a review from ernestognw January 22, 2024 12:31
contracts/token/ERC1155/utils/ERC1155Utils.sol Outdated Show resolved Hide resolved
contracts/token/ERC1155/utils/ERC1155Utils.sol Outdated Show resolved Hide resolved
contracts/token/ERC1155/utils/ERC1155Utils.sol Outdated Show resolved Hide resolved
contracts/token/ERC1155/utils/ERC1155Utils.sol Outdated Show resolved Hide resolved
.changeset/poor-chefs-cheat.md Outdated Show resolved Hide resolved
contracts/token/ERC721/utils/ERC721Utils.sol Outdated Show resolved Hide resolved
contracts/token/ERC721/utils/ERC721Utils.sol Outdated Show resolved Hide resolved
Amxx and others added 3 commits January 30, 2024 14:33
Co-authored-by: Ernesto García <ernestognw@gmail.com>
ernestognw
ernestognw previously approved these changes Jan 30, 2024
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestognw ernestognw enabled auto-merge (squash) January 30, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants