Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SignatureChecker EIP-7377 safe #4951

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 12, 2024

Fixes #4855

PR Checklist

  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 7374945

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx
Copy link
Collaborator Author

Amxx commented Mar 12, 2024

Capture d’écran du 2024-03-12 17-28-10
Relevant gas measurement:

  • Best case becomes more expensive
  • Worst case becomes cheaper
  • On average (over our tests) it is slightly cheaper

Purpose of the change is mostly security, not gas costs

@Amxx Amxx requested a review from ernestognw March 12, 2024 19:27
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's just discuss the changeset.

.changeset/yellow-moles-hammer.md Outdated Show resolved Hide resolved
ernestognw
ernestognw previously approved these changes Mar 14, 2024
@ernestognw ernestognw merged commit 33ea111 into OpenZeppelin:master Mar 14, 2024
20 checks passed
@Amxx Amxx deleted the features/eip-7377-safety branch March 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants