Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transient storage slot support in StorageSlot.sol #4980

Merged
merged 17 commits into from
Apr 3, 2024
Merged

Add transient storage slot support in StorageSlot.sol #4980

merged 17 commits into from
Apr 3, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 28, 2024 •
edited
Loading

Replaces #4965
Fixes #4961

Blocked by the hardhat-exposed issue: see this

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1d43d23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx added this to the 5.1 milestone Mar 28, 2024
@Amxx Amxx mentioned this pull request Mar 28, 2024
Closed
3 tasks
@socket-security Socket Security
Copy link

socket-security bot commented Mar 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/hardhat-exposed@0.3.15 filesystem 0 138 kB frangio
npm/hardhat-gas-reporter@1.0.10 filesystem Transitive: environment, eval, network, shell, unsafe +178 45.9 MB cgewecke
npm/hardhat-ignore-warnings@0.2.11 Transitive: filesystem +15 3.77 MB frangio
npm/hardhat@2.22.2 environment, filesystem, network, shell Transitive: eval, unsafe +261 238 MB alcuadrado

🚮 Removed packages: npm/hardhat-exposed@0.3.14-0, npm/hardhat-gas-reporter@2.0.2, npm/hardhat-ignore-warnings@0.2.9, npm/hardhat@2.17.4

View full report↗︎

Amxx
Amxx commented Mar 28, 2024
View reviewed changes
contracts/utils/StorageSlot.sol Outdated Show resolved Hide resolved
Amxx
Amxx commented Mar 28, 2024
View reviewed changes
hardhat.config.js Outdated Show resolved Hide resolved
ernestognw
ernestognw previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a quick example in the utilities page.

LGTM

@ernestognw ernestognw changed the title Add storage slot support in StorageSlot.sol Add transient storage slot support in StorageSlot.sol Apr 3, 2024
@Amxx
Copy link
Collaborator Author

Amxx commented Apr 3, 2024

Last changes look good to me

ernestognw
ernestognw previously approved these changes Apr 3, 2024
View reviewed changes
@Amxx Amxx merged commit d6ad9db into OpenZeppelin:master Apr 3, 2024
19 checks passed
@Amxx Amxx deleted the features/expended-storage-slot-v2 branch April 3, 2024 23:15
@Amxx Amxx mentioned this pull request Apr 3, 2024
Merged
1 task
This was referenced Nov 8, 2024
Open
Open
This was referenced Nov 9, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Library for derivation of slots
2 participants
@Amxx @ernestognw