Transient version of ReentrancyGuard

[Amxx]

Fixes #4205
Fixes #4888
Replace #4955

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

🦋 Changeset detected

Latest commit: 0b73212

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
openzeppelin-solidity	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[fuelfoundry]

Apologies if this has already been brought up elsewhere, but is anyone else getting:

Warning: Unreachable code.
--> @openzeppelin/contracts/utils/ReentrancyGuard.sol:58:9:
|
58 | _nonReentrantAfter();
| ^^^^^^^^^^^^^^^^^^^^

Weirdly I only started seeing this today, it's balking at the modifier; gotta be the IDE just trippin.

Respectfully,
-T

[Amxx]

@fuelfoundry there has been no change to the non-transient reentrancy guard in this PR.

Could you make a minimal reproductible example and open an issue ?

[fuelfoundry]

Thank you for reaching out, turns out it's a non-issue. Upon review, it appears during a previous code reorganization I implemented a unnecessarily overly secure fallback function, more out of an abundance of caution, as shown below:

fallback() external payable nonReentrant { revert("tisk, tisk..."); }