Replace deprecated throw with assert in Solidity tests #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
test/helpers/ReentrancyAttack.sol
andtest/helpers/ReentrancyMock.sol
usedthrow
which has been deprecated since 0.4.13Replacing them with
assert
s removes the two ugly error messages that have plagued the tests https://travis-ci.org/OpenZeppelin/zeppelin-solidity/jobs/289039499#L535