-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify hardhat & foundry configs and enable optimisation by default. #5099
Conversation
|
Moved that part to a separate PR OpenZeppelin#5099
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way cleaner, thanks! Just left a qustion
should we also clarify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Before this PR:
GAS
orCOVERAGE
(default). This results in:All this was not necessarily clear. In particular, the fact that by default, out local tests run in a mode that doesnt match the CI (unless we have some
.env
to override that). Also, setting theIR
flag has no effect unless you also enable optimization (either through the production mode, or implicitelly when doing gas or coverage checks)This PR does the following changes:
Note